libplatsupport: Add support for imx8mp-evk #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indanz
approved these changes
May 16, 2024
Indanz
reviewed
May 16, 2024
| # For the imx8mp, the DTS is in a different format compared to those of | ||
| # the imx8mm and imx8mq, there are some constants in the headers that | ||
| # point to the proper path | ||
| target_compile_definitions(platsupport PRIVATE USE_IMX8MP_GPT_PATH) |
There was a problem hiding this comment.
You could use #ifdef CONFIG_PLAT_IMX8MP_EVK below and avoid this, that would be more in line with the existing code. If it gets messy in the future we can always add defines, also for serial. But if you prefer it this way then that's fine with me too.
The i.MX 8M Plus Evaluation Kit is similar to the other platforms in the i.MX 8M family and shares the same serial and timer peripherals. Signed-off-by: Damon Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The i.MX 8M Plus Evaluation Kit is similar to the other platforms in the i.MX 8M family and shares the same serial and timer peripherals.