Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mach timer.h to use axi instead of amba #169

Closed
wants to merge 1 commit into from

Conversation

chrisguikema
Copy link
Contributor

Test with: seL4/seL4#1102

@axel-h
Copy link
Member

axel-h commented Sep 7, 2023

Updates to the kernel device tree forces this change.

Can you extend this comment comment with some version details, so it gets more transparent where this happened. Guessing from your branch name it seems peta linux 2021.1 needs this?

The kernel can support using a newer petalinux version, which updates
the main bus to "axi" instead of "amba". The kernel presents a config
variable, which we check against to define the proper TTC paths.

Signed-off-by: Chris Guikema <[email protected]>
@chrisguikema
Copy link
Contributor Author

Updates to the kernel device tree forces this change.

Can you extend this comment comment with some version details, so it gets more transparent where this happened. Guessing from your branch name it seems peta linux 2021.1 needs this?

Done.

I updated the kernel PR to add the option to select a specific petalinux version

@axel-h
Copy link
Member

axel-h commented Sep 13, 2023

I updated the kernel PR to add the option to select a specific petalinux version

This seem to allows some transition then. But I wonder it such a config option is really needed practically. We could just move on and support a newer version (where the commit comment says, what version this is). If the expect everybody to move to this version anyway, there is not much gain keeping support for older version. Or you have to keep your own fork then for legacy support.
I wonder if a long term solution must be factoring this out of the C code into some config file, so we can have profiles.

@chrisguikema
Copy link
Contributor Author

But I wonder it such a config option is really needed practically.

I agree with you. But a theme of the PRs I've made is not breaking existing features/support. While updating to 2021.1 now would probably be okay, once zcu102 configurations are released to camkes-vm-apps, then future updates to the kernel would be breaking. This feels like a good compromise, where we can just release a new version without introducing any breaking changes.

@chrisguikema
Copy link
Contributor Author

Not needed based on kernel PR feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants