Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: check that astyle exists #204

Merged
merged 1 commit into from
Jul 15, 2024
Merged

misc: check that astyle exists #204

merged 1 commit into from
Jul 15, 2024

Conversation

Ivan-Velickovic
Copy link
Contributor

We use the seL4 style check for sDDF and most people who try to run the style check offline end up running into weird issues since they don't have it installed.

Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

astyle is of course described as a dependency in the setup instructions, but let's not rely on that.

@Ivan-Velickovic
Copy link
Contributor Author

astyle is of course described as a dependency in the setup instructions, but let's not rely on that.

I have it in the sDDF CI README as well but it's not enough :)

Signed-off-by: Ivan Velickovic <[email protected]>
@Ivan-Velickovic Ivan-Velickovic merged commit 91c8795 into master Jul 15, 2024
20 checks passed
@Ivan-Velickovic Ivan-Velickovic deleted the check_for_astyle branch July 15, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants