elfloader: make check more intuitive #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsf37
reviewed
Aug 9, 2024
| if (initialise_devices_non_boot()) { | ||
| if (0 != initialise_devices_non_boot()) { |
There was a problem hiding this comment.
I don't find this more intuitive. The return type of initialise_devices_non_boot is currently int, but it is only used as bool. Should we not change it to bool instead?
There was a problem hiding this comment.
You have a point here. The current scheme allows returning different error codes, I can make this even more clear and then also print the code in the message.
Signed-off-by: Axel Heider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been extracted from a bigger patchset to improve the code maintainability/extendability.