Fix RISC-V compilation with recent GCC #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems this is seL4/seL4#749 again. This change here seem to copy what we did in seL4/seL4#776 |
Default args for gcc have changed; we need to fix the args given to the compiler. This is needed in addition to seL4/seL4#776 Signed-off-by: Peter Chubb <[email protected]>
Yes, but the fix there didn't fix all the flags. |
Github wants 4-space indents. Signed-off-by: Peter Chubb <[email protected]>
You are referring to the CMake flags that are specific to OpenSBI, not some missing gcc flags, right? Because the change seem to be an exact copy of the flags. |
|
Yep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default args for gcc have changed; we need to fix the args given to the compiler.