vmmplatsupport, vesa: fix vesa mapping #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisguikema
force-pushed
the
vesa_framebuffer_fix
branch
from
801fbcb
to
206b093
Compare
abrandnewusername
approved these changes
Oct 31, 2023
| @@ -92,18 +93,19 @@ static void make_guest_screen_info(vm_t *vm, struct screen_info *info) | |||
| } | |||
| if (error) { | |||
| ZF_LOGE("Failed to map vbe protected mode interface for VESA frame buffer. Disabling"); | |||
There was a problem hiding this comment.
The error message need to be coherent with the behavior
There was a problem hiding this comment.
Switched to "Not Disabling".
The previous behavior would only attempt to map the vesa framebuffer and set the screen info struct if the vbe protection mode interface was successfully mapped in. This removes the dependency on the vbe protected mode interface. It is not clear that it is needed as vesa framebuffer passthrough works without it. Signed-off-by: Chris Guikema <[email protected]>
chrisguikema
force-pushed
the
vesa_framebuffer_fix
branch
from
206b093
to
e675a71
Compare
|
Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior would only attempt to map the vesa framebuffer and set the screen info struct if the vbe protection mode interface was successfully mapped in. This removes the dependency on the vbe protected mode interface. It is not clear that it is needed as vesa framebuffer passthrough works without it.