Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce l4v/Isabelle image size #67

Merged
merged 2 commits into from
Feb 12, 2024
Merged

reduce l4v/Isabelle image size #67

merged 2 commits into from
Feb 12, 2024

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented Feb 10, 2024

The l4v image has gotten too large to even just pull from within a GitHub action (about 3GB).

This PR removes some old obsolete settings and reduces the images size:

  • use default polyml32_64 builds, which go up to 16GB of heap size, which was the max before anyway. This should reduce heap size.
  • remove vscodium component from cache (saves > 1GB)
  • remove separate MLTon download, which is now an Isabelle component anyway

@lsf37 lsf37 self-assigned this Feb 10, 2024
@lsf37 lsf37 requested a review from corlewis February 10, 2024 00:41
@lsf37 lsf37 force-pushed the isabelle-update branch 2 times, most recently from 00cd4a2 to ffa0933 Compare February 10, 2024 10:32
@lsf37
Copy link
Member Author

lsf37 commented Feb 10, 2024

It looks like l4v is also downloading another ghc installation in addition to what the camkes image already provides. Ideally we should also eliminate that, but if this build succeeds it's already better than before and we should probably make that a separate PR.

res/isabelle_settings Outdated Show resolved Hide resolved
res/isabelle_settings Outdated Show resolved Hide resolved
- use default polyml32_64 builds, which go up to 16GB of heap size,
  which was the max before anyway. This should reduce heap size.

- remove vscodium component from cache (saves > 1GB)

- remove separate MLTon download, which is now an Isabelle component
  anyway

Signed-off-by: Gerwin Klein <[email protected]>
@lsf37
Copy link
Member Author

lsf37 commented Feb 12, 2024

Btw, the total image size of the l4v image is still about 16GB after this change (down from around 18GB). Probably worth looking into again in the future.

@lsf37 lsf37 merged commit e632786 into master Feb 12, 2024
10 checks passed
@lsf37 lsf37 deleted the isabelle-update branch February 12, 2024 09:37
@LukeMondy
Copy link
Contributor

I have a vague memory that the latex packages took up a lot of room. Maybe an l4v-slim image could be made for builds?

@lsf37
Copy link
Member Author

lsf37 commented Feb 13, 2024

I have a vague memory that the latex packages took up a lot of room. Maybe an l4v-slim image could be made for builds?

It's possible that this is one of the major contributors, yes. Unfortunately, even some of the basic builds already do need latex (and with a lot of packages), so I don't think we can leave it out.

Two other major blocks of storage are the Isabelle heap images (the cache) and the Isabelle contrib files. I don't think there is much we can do about the heap images, but we could look into removing binaries for other architectures from the contrib install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants