crates/drivers: Initialize serial device in new()

Signed-off-by: Nick Spinale <[email protected]>
seL4 · Jun 12, 2024 · e430ff5 · e430ff5
1 parent 2db6cb4
commit e430ff5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/crates/drivers/sel4-pl011-driver/src/lib.rs b/crates/drivers/sel4-pl011-driver/src/lib.rs
@@ -31,7 +31,7 @@ impl Driver {
         this
     }
 
-    pub fn init(&mut self) {
+    fn init(&mut self) {
         self.device.init();
     }
 }

diff --git a/crates/examples/microkit/banscii/pds/serial-driver/src/main.rs b/crates/examples/microkit/banscii/pds/serial-driver/src/main.rs
@@ -16,8 +16,7 @@ const ASSISTANT: Channel = Channel::new(1);
 
 #[protection_domain]
 fn init() -> Driver<DriverImpl> {
-    let mut driver_impl =
+    let driver_impl =
         unsafe { DriverImpl::new(memory_region_symbol!(pl011_register_block: *mut ()).as_ptr()) };
-    driver_impl.init();
     Driver::new(driver_impl, DEVICE, ASSISTANT)
 }