Minor manual fixes #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Ivan-Velickovic
force-pushed
the
zcu102_docs
branch
from
c29e7be
to
7e7899d
Compare
axel-h
reviewed
Jan 11, 2024
|
|
||
| => go 0x40000000 | ||
|
|
||
| Note that the loading address must be `0x40000000`. |
There was a problem hiding this comment.
If you add this note, you should also say, why it must be this address? The note's wording feels a bit odd now to me.
There was a problem hiding this comment.
I can remove the note or say something like 'The image expects to be loaded at 0x40000000'. I added the note because I wanted to make it clear that it's a fixed address. The reasoning for the fixed address is explained in the section about adding platform support, it will also be explained once #49 is resolved.
I think I will probably just remove the note to make it consistent with the TQMa8XQP documentation.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spelling mistakes and adds instructions for booting on ZCU102 hardware. Closes #30.
In the future we need to find out how to integrate the documentation for each board with the official seL4 documentation. Including how to setup U-Boot etc is too much for the Microkit manual most likely but I still believe that the manual should include instructions specific to Microkit should remain in the manual.