Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added concat of headers as a build output #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isubasinghe
Copy link

Motivation

These artefacts are needed as part of the verification pipeline, these concatenated files are cleaned and then fed into the C parser.

monitor/Makefile Outdated Show resolved Hide resolved
We need to concatenate and preprocess all the C source files
in order to run verification tooling.

Signed-off-by: isubasinghe <[email protected]>
@Ivan-Velickovic
Copy link
Collaborator

I've changed the build to produce main_verification.c so it's obvious what it's for. With the seL4 kernel build artifacts it's hard to know with the naming convention what is used for what. Any opinions @lsf37 before I merge?

@lsf37
Copy link
Member

lsf37 commented Dec 4, 2023

No opinions from me on that one. Ideally, the concatenated C file that the verification sees should also be what the compiler gets, unless you are also planning to do binary verification. We're no longer doing that for the kernel (there it's because of BV), but if you want to eliminate the preprocessor from the trust chain, then that's the way to do it.

@Ivan-Velickovic
Copy link
Collaborator

No opinions from me on that one. Ideally, the concatenated C file that the verification sees should also be what the compiler gets

Okay yes we should definitely do that then. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants