update to Isabelle 2023 #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Setting this to draft for now, because we should merge the other larger PRs first and then rebase this one) |
lsf37
force-pushed
the
isabelle-2023
branch
3 times, most recently
from
decdaae
to
2cbf067
Compare
|
This is now ready for review. The last commit needs to be dropped before merging (it just makes the tests pick Isabelle2023 instead of Isabelle2022 for the PR). |
corlewis
approved these changes
Oct 6, 2023
That makes sense, the current set is mostly how they were constructed. I'll squash them into larger sets. |
Signed-off-by: Gerwin Klein <[email protected]>
Signed-off-by: Gerwin Klein <[email protected]>
Signed-off-by: Gerwin Klein <[email protected]>
Signed-off-by: Rafal Kolanski <[email protected]>
michaelmcinerney
approved these changes
Oct 6, 2023
| (s\<lparr>kheap := kheap s(thread \<mapsto> | ||
| TCB (tcb'\<lparr>tcb_arch := arch_tcb_context_set c' (tcb_arch tcb')\<rparr>))\<rparr>)" | ||
| (s\<lparr>kheap := (kheap s) | ||
| (thread \<mapsto> TCB (tcb'\<lparr>tcb_arch := arch_tcb_context_set c' (tcb_arch tcb')\<rparr>))\<rparr>)" |
There was a problem hiding this comment.
I think I'd prefer the previous indentation
Signed-off-by: Gerwin Klein <[email protected]>
Signed-off-by: Gerwin Klein <[email protected]>
Signed-off-by: Gerwin Klein <[email protected]>
The code draws in table.ML from the Isabelle source, which changed in the 2023 release. This commit adds further library functions from Isabelle library.ML and extracts the parts of unsynchronized.ML that work with mlton. Signed-off-by: Gerwin Klein <[email protected]>
Signed-off-by: Gerwin Klein <[email protected]>
Signed-off-by: Gerwin Klein <[email protected]>
Signed-off-by: Gerwin Klein <[email protected]>
Signed-off-by: Gerwin Klein <[email protected]>
Signed-off-by: Gerwin Klein <[email protected]>
Signed-off-by: Gerwin Klein <[email protected]>
Signed-off-by: Gerwin Klein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all proofs and ML code to Isabelle2023.
Changes are fairly minor this time. A few tweaks in ML where functions get more parameters (location info and similar). Mostly these are filled with
Noneor default values unless something is specifically available to put in.On the proof side, the only larger change is that the syntax precedence of the "mapsto" arrow has changed from
f t (x |-> y)to(f t) (x |-> y), which is arguably clearer and easier to read in most cases.Haven't noticed any major performance impact, but we'll see more comparable numbers when the AWS tests come in.