Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support LLVM for RISCV64 kernel stand alone build #297

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

axel-h
Copy link
Member

@axel-h axel-h commented Jan 5, 2024

See seL4/seL4#1154 for a test run

Signed-off-by: Axel Heider <[email protected]>
@axel-h axel-h requested a review from lsf37 as a code owner January 5, 2024 09:58
@lsf37 lsf37 added the seL4 actions on the kernel repo label Jan 8, 2024
Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. And I see the test worked as well. Nice.

We had previously excluded clang for RISCV, because there were some problems. Have these been fixed or is it just that more recent compiler versions now work?

@axel-h
Copy link
Member Author

axel-h commented Jan 8, 2024

No sure if somebody was actively tracking this. LLVM has been working for me for some time now.

@lsf37
Copy link
Member

lsf37 commented Jan 8, 2024

Cool, we should try switching on clang for more of the RISCV tests then.

@lsf37 lsf37 merged commit 702d24c into seL4:master Jan 8, 2024
7 checks passed
@axel-h axel-h deleted the patch-axel-1 branch January 9, 2024 06:37
@axel-h
Copy link
Member Author

axel-h commented Jan 9, 2024

What I'm still not sure about is what clang triple we prefer and why we do this: riscv64-unknown-elf or riscv64-linux-gnu

@lsf37
Copy link
Member

lsf37 commented Jan 9, 2024

For the pure compilation check I don't think it actually matters for the kernel, because we're not linking with any libraries anyway. I guess that makes the more "honest" one riscv64-unknown-elf

@axel-h
Copy link
Member Author

axel-h commented Jan 9, 2024

True. Wwe no longer have riscv64-linux-gnu anyway. I was just fooled again by some other scripts that still contain this, but it is completely unused and thus there was never an issues. More PRs to come...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
seL4 actions on the kernel repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants