Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic CI test #120

Closed
wants to merge 4 commits into from
Closed

Conversation

axel-h
Copy link
Member

@axel-h axel-h commented Jan 24, 2024

@axel-h axel-h force-pushed the patch-axel-ci-1 branch 6 times, most recently from 9393c5f to aa64e91 Compare January 24, 2024 18:22
@axel-h axel-h added the hw-test camkes-vm-examples hardware builds + runs for this PR label Jan 24, 2024
@axel-h
Copy link
Member Author

axel-h commented Jan 24, 2024

@chrisguikema It seems to run the new test now, but there is an problem with the image name. Seems "zynqmp" is deep in the defaults. Either we clean this up to have a nice strong SOC/board differentiation or accept this as legacy for now to get things merged and have the board covered at least.

@chrisguikema
Copy link
Contributor

Axel, thanks for doing this! I think we're gonna need @lsf37's opinion here. When you build for the ultra96, or the zcu102, or any variant of the ZUS+ platform, the resulting image is always capdl-loader-image-arm-zynqmp. However, it looks like the CI scripts expect the capdl-loader-image-arm-<SPECIFIC_PLATFORM> instead.

https://github.com/seL4/ci-actions/blob/master/camkes-vm/build.py#L59

We may be able to add another piece of logic in the get_platform function here: https://github.com/seL4/ci-actions/blob/08c98dc30fac13105aec51124a38206ab572944c/seL4-platforms/platforms.py#L147

But like I said, I'll wait for Gerwin to respond here, since there are a few ways we can go about this.

@chrisguikema
Copy link
Contributor

@axel-h can you rerun this? I added the image_platform which seems to exist solely to solve the problem we ran into.

@axel-h
Copy link
Member Author

axel-h commented Jan 24, 2024

just push another dummy commit to my branch https://github.com/axel-h/camkes-vm/tree/patch-axel-ci-1 then this PR's CI runs again.

@chrisguikema
Copy link
Contributor

I tried that, and it wouldn't let me push to your branch

@axel-h
Copy link
Member Author

axel-h commented Jan 24, 2024

ok, i will do a dummy push then latwr. You could make a new draft PR from your own branch that tragets https://github.com/seL4/camkes-vm/tree/patch-axel-ci-base instead of master, that will also work.

@axel-h axel-h added hw-test camkes-vm-examples hardware builds + runs for this PR and removed hw-test camkes-vm-examples hardware builds + runs for this PR labels Jan 24, 2024
@axel-h
Copy link
Member Author

axel-h commented Jan 24, 2024

or well, removing and adding the hw-test label also triggered a re-run now

The seL4 kernel uses an older device tree. In order to make the kernel
device tree compatible with the VMM device tree generation, older
Linux artifacts are needed. This commit makes 2018.3 the default, with
the option for users to use newer artifacts if needed.

Signed-off-by: Chris Guikema <[email protected]>
@axel-h axel-h removed the hw-test camkes-vm-examples hardware builds + runs for this PR label Jan 26, 2024
@axel-h axel-h added the hw-test camkes-vm-examples hardware builds + runs for this PR label Jan 26, 2024
@axel-h axel-h force-pushed the patch-axel-ci-1 branch 3 times, most recently from 05cf94a to 877fd54 Compare January 27, 2024 01:13
Signed-off-by: Axel Heider <[email protected]>
@lsf37
Copy link
Member

lsf37 commented Jan 27, 2024

The CI support is merged now.

@lsf37 lsf37 closed this Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hw-test camkes-vm-examples hardware builds + runs for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants