-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init: add hooks for hpet emulation #113
Conversation
8147333
to
9b24401
Compare
The build only seems to be failing because the "Test with" isn't working. Did I mess something up? |
The "Test with" has to be in the PR description, not in a comment. I'll update. |
Thanks, Gerwin! I'll remember that for next time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. It will be nice to have a VM example that demonstrates/tests HPET emulation.
Do we even have a test application for a 64-bit guest? If not, I can make one, and have it use the HPET emulation. |
8af8017
to
4f2d180
Compare
For what its worth, I added a flag to the |
4f2d180
to
e35dfe5
Compare
b9ffb13
to
dd15dc2
Compare
Alright, so y'all will have to manually test the HPET emulation. CI testing doesn't work because 64-bit VMs have a different file name than the Runner is expecting: https://github.com/seL4/camkes-vm/actions/runs/6697978462/job/18199249921#step:4:1299 And I can't test 32-bit VMs because they don't have HPET support compiled in. |
dd15dc2
to
62e865c
Compare
@abrandnewusername Have you been able to look at this? |
62e865c
to
9b6c695
Compare
I updated the 32-bit Linux image to support the HPET, and it looks like the tests are failing. The
@abrandnewusername do you want me to update the |
9b6c695
to
27c073e
Compare
@abrandnewusername I was able to work with @lsf37 to create a 64-bit guest test. The minimal_64 test worked on a hardware run, with the clocksource switching to the hpet: https://github.com/seL4/camkes-vm/actions/runs/6869868181/job/18683754338?pr=113#step:4:2791 What needs to happen to get this feature merged? Do I need to update the dependency to be a 64-bit guest? |
27c073e
to
3f6ce05
Compare
This allows VMs to use the HPET for higher-precision timing. Signed-off-by: Chris Guikema <[email protected]>
3f6ce05
to
d7bfd80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much experience with HPET so I can't comment on the actual HPET emulation code. Apart from that, everything else is good to go.
This allows VMs to emulate the HPET for higher-precision timing.
Test with: seL4/seL4_projects_libs#117, seL4/camkes-vm-examples#51