-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zynqmp, ultra96v2: add linux images #6
Conversation
Please provide a |
5dbf23d
to
a49c879
Compare
I added a README as seen in other directories. @lsf37 Any insight on how to get the License check to pass? |
For files that don't allow inline comments, you can add a license and copyright to the |
a49c879
to
7b1f5e3
Compare
Thanks, that was really straight forward! |
This PR looks ok now, but what is the merge criterion? There seems a ZCU102 board in CI, having this images now allows activation the VM tests. So passing at least the minimal VM example would be the goal? |
See my comment in seL4/camkes-vm#42 for why a minimal example isn't yet feasible. |
@lsf37 @kent-mcleod what is the criteria to merge this? These images won't run until the SMC RFC is handled, so is it okay to let this sit? Or would it be better to merge, and then they'll be used in an example in the future? |
Maybe let them sit as they can't break due to other code changes |
@kent-mcleod Now that the SMC commits have been reviewed, this could probably be merged. I'll create a PR for a vm_minimal and vm_virtio_net for the zynqmp platform. |
e79c298
to
30d4a85
Compare
06b0e52
to
949d23a
Compare
Seems the files in the folders |
They're different:
The big difference with the Ultra96 is that the serial port is on the |
This commit adds Petalinux-2021.1 prebuilt images for the zynqmp. Signed-off-by: Chris Guikema <[email protected]>
949d23a
to
a166d5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me to merge this.
For the Ultra96 (where you removed the files) I am not sure how to handle it. It is a nice board actually, but unfortunately no longer available - so that puts it at a dead end somehow. But there is some support for this platform, so I think we could also merge these images then for more completness?
Yeah, that's unfortunate about the U96. Though i'm sure there are other cheap development platforms that use the ZUS+ processor. @lsf37 can this be merged? |
This commit adds Petalinux-2021.1 prebuilt images for the zynqmp and ultra96v2 platforms.