Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting Function for Arm VM core pinning #122

Closed
wants to merge 1 commit into from

Conversation

Apave24
Copy link

@Apave24 Apave24 commented Nov 11, 2022

This commit adds supporting functionality for adding a pcpu list attribute to the VM_Arm component for specially defining what physical cpus a VM's vcpus should be pinned to.

Test with: seL4/camkes-vm#54

Copy link
Member

@axel-h axel-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. we could do more sanity checks (duplicates...), but that can also be a follow-up.

@kent-mcleod
Copy link
Member

kent-mcleod commented Nov 22, 2022

CAmkES has a mechanism for adding templates to a component (https://github.com/seL4/camkes-tool/blob/master/camkes.cmake#L606-L607). VM specific configuration to be passed into the VM_Arm component should be implemented using a VM_Arm specific template instead of the base component templates. For an example, the recent additions of the seL4AllocatorMempool configuration (https://github.com/seL4/camkes-vm/blob/master/arm_vm_helpers.cmake#L134-L137) use the same approach.

@Apave24
Copy link
Author

Apave24 commented Dec 9, 2022

CAmkES has a mechanism for adding templates to a component (https://github.com/seL4/camkes-tool/blob/master/camkes.cmake#L606-L607). VM specific configuration to be passed into the VM_Arm component should be implemented using a VM_Arm specific template instead of the base component templates. For an example, the recent additions of the seL4AllocatorMempool configuration (https://github.com/seL4/camkes-vm/blob/master/arm_vm_helpers.cmake#L134-L137) use the same approach.

Moved commit to camkes-vm#54

@axel-h
Copy link
Member

axel-h commented Mar 10, 2023

@Apave24 could you rebase this, then we also get another CI run there to see if this passes.

@axel-h
Copy link
Member

axel-h commented Mar 13, 2023

The build fails, because seL4/camkes-vm#54 depends on #121.

@axel-h
Copy link
Member

axel-h commented Apr 19, 2023

CAmkES has a mechanism for adding templates to a component (https://github.com/seL4/camkes-tool/blob/master/camkes.cmake#L606-L607). VM specific configuration to be passed into the VM_Arm component should be implemented using a VM_Arm specific template instead of the base component templates. For an example, the recent additions of the seL4AllocatorMempool configuration (https://github.com/seL4/camkes-vm/blob/master/arm_vm_helpers.cmake#L134-L137) use the same approach.

Since we have a component specific template in seL4/camkes-vm#54, it seem this is obsolete now and can be closed?

@axel-h axel-h self-requested a review April 19, 2023 12:41
@kent-mcleod
Copy link
Member

Since we have a component specific template in seL4/camkes-vm#54, it seem this is obsolete now and can be closed?

Closing due to ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants