Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to sdss/valis#57 and updates the client-side store functions to better handle non-unique database metadata. With PR sdss/valis#57 the response from
info/database
now returns a dictionary of schema, with keys{table}.{column}
whereas before it was organized by{column}
only. The front-end now organizes the database metadata by{schema}.{table}.{column}
for more unique keys, for cases where multiple table and schema have the same column name, but different metadata. The store functionstore.get_field_from_db
now accepts an optional context object specifying a preferred schema or table to use when looking up the field metadata. e.g.store.get_field_from_db('sdss_id', 'description', {'schema': 'vizdb'})
will pull the description of thesdss_id
column from the best matching column in thevizdb
schema.