Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to db metadata #69

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Updates to db metadata #69

merged 1 commit into from
Sep 30, 2024

Conversation

havok2063
Copy link
Contributor

This PR is related to sdss/valis#57 and updates the client-side store functions to better handle non-unique database metadata. With PR sdss/valis#57 the response from info/database now returns a dictionary of schema, with keys {table}.{column} whereas before it was organized by {column} only. The front-end now organizes the database metadata by {schema}.{table}.{column} for more unique keys, for cases where multiple table and schema have the same column name, but different metadata. The store function store.get_field_from_db now accepts an optional context object specifying a preferred schema or table to use when looking up the field metadata. e.g. store.get_field_from_db('sdss_id', 'description', {'schema': 'vizdb'}) will pull the description of the sdss_id column from the best matching column in the vizdb schema.

@havok2063 havok2063 added the enhancement New feature or request label Sep 30, 2024
@havok2063 havok2063 self-assigned this Sep 30, 2024
@havok2063 havok2063 merged commit b853b4a into main Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant