Try-excepts attemps to write to modbus

sdss · Dec 5, 2023 · 9a095d4 · 9a095d4
1 parent 2971966
commit 9a095d4
Showing 1 changed file with 19 additions and 13 deletions.
diff --git a/python/lvmecp/modbus.py b/python/lvmecp/modbus.py
@@ -162,23 +162,29 @@ async def set(self, value: int | bool):
                 else:
                     raise ValueError(f"Invalid block mode {self.mode!r}.")
 
-                if self.client.connected:
-                    resp = await func(self.address, value)  # type: ignore
-                else:
-                    async with self.modbus:
+                try:
+                    if self.client.connected:
                         resp = await func(self.address, value)  # type: ignore
+                    else:
+                        async with self.modbus:
+                            resp = await func(self.address, value)  # type: ignore
 
-                if resp.function_code > 0x80:
-                    msg = (
-                        f"Invalid response for element "
-                        f"{self.name!r}: 0x{resp.function_code:02X}."
-                    )
+                    if resp.function_code > 0x80:
+                        msg = (
+                            f"Invalid response for element "
+                            f"{self.name!r}: 0x{resp.function_code:02X}."
+                        )
+                    else:
+                        return
 
-                    if ntries >= MAX_RETRIES:
-                        raise ValueError(msg)
+                except Exception as err:
+                    msg = f"Error raised while setting {self.name!r}: {err}"
 
-                    warnings.warn(msg, ECPWarning)
-                    await asyncio.sleep(0.5)
+                if ntries >= MAX_RETRIES:
+                    raise ValueError(msg)
+
+                warnings.warn(msg, ECPWarning)
+                await asyncio.sleep(0.5)
 
 
 class Modbus(dict[str, ModbusRegister]):