Merge pull request #190 from sdss/skyQA_dev

Fix to shadow height calculation
sdss · Jan 7, 2025 · 6a562fc · 6a562fc
2 parents e75100a + 89a4256
commit 6a562fc
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/python/lvmdrp/core/sky.py b/python/lvmdrp/core/sky.py
@@ -818,10 +818,10 @@ def get_telescope_shadowheight(header, telescope):
     jd = time.jd
 
     SH_CALCULATOR.update_time(jd=jd)
-    sk = SkyCoord(ra=ra, dec=dec, unit="deg")
-    SH_CALCULATOR.set_coordinates(sk.ra, sk.dec)
+    sk = SkyCoord(ra, dec, frame='icrs', unit=u.deg)
+    SH_CALCULATOR.set_coordinates(sk.ra.deg, sk.dec.deg)
 
-    shadow_height = SH_CALCULATOR.get_heights()[0]
+    shadow_height = SH_CALCULATOR.get_heights(return_heights=True, unit="km")[0]
 
     # check if the shadow height is a nan value and replace with -999
     isnan = np.isnan(shadow_height)