-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add network mounted volumes[WIP] #223
Open
angad-k
wants to merge
25
commits into
develop
Choose a base branch
from
network-mounted-volumes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functions for setting up docker containers for seaweedfs No breaking changes AFAIK
… to its own handler.go move code pertaining to seaweedfs from database handler to its own handler no breaking changes
…ervicename for seaweed containers replace the seaweed container names' strings with types.servicename format no breaking changes
… add persistence to seaweedfs mount previously unmounted seaweedfs container on local storage no breaking changes
…asper to check whether seaweedfs plugin is installed the docker plugin that will be used to create network mounted volumes previously had to be externally installed. Now, gasper checks for and installs the plugin automatically no breaking changes
… network mounted volumes to redis_gasper and mongodb_gasper I have added support to create network mounted volumes using seaweedfs and its docker plugin and tried it on redis_gasper and mongodb_gasper in this commit. It still needs to be checked for stability. Possiblity of breaking changes because of usage of network mounted volumes
Seaweedfs's volume driver wasn't stable so, shifted over to lizardfs No breaking changes
… at some places change seaweedfs to lizardfs at some last remaining places no breaking changes
import seaweedfs into the codebase and use seaweedFS mounted directly instead of running seaweedFS in a container database containers mostly can't be deployed properly after this commit
… was put in for testing remove uneeded mysql container deployment from service-launcher.go database containers deployment still doesn't work properly
Add functions for setting up docker containers for seaweedfs No breaking changes AFAIK
… to its own handler.go move code pertaining to seaweedfs from database handler to its own handler no breaking changes
…ervicename for seaweed containers replace the seaweed container names' strings with types.servicename format no breaking changes
… add persistence to seaweedfs mount previously unmounted seaweedfs container on local storage no breaking changes
…asper to check whether seaweedfs plugin is installed the docker plugin that will be used to create network mounted volumes previously had to be externally installed. Now, gasper checks for and installs the plugin automatically no breaking changes
… network mounted volumes to redis_gasper and mongodb_gasper I have added support to create network mounted volumes using seaweedfs and its docker plugin and tried it on redis_gasper and mongodb_gasper in this commit. It still needs to be checked for stability. Possiblity of breaking changes because of usage of network mounted volumes
Seaweedfs's volume driver wasn't stable so, shifted over to lizardfs No breaking changes
… at some places change seaweedfs to lizardfs at some last remaining places no breaking changes
import seaweedfs into the codebase and use seaweedFS mounted directly instead of running seaweedFS in a container database containers mostly can't be deployed properly after this commit
… was put in for testing remove uneeded mysql container deployment from service-launcher.go database containers deployment still doesn't work properly
…gasper into network-mounted-volumes
add functionality to stop databases on ctrl c which doesnt work yet databases dont work correctly in this
@angad-k Can you specify in the PR description what all things are WIP for this PR and what all are covered. Would be easy to review then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the database contents are being uploaded correctly to seaweedfs. However, on terminating gasper, because seaweedfs is running as a thread in it, seaweedfs gets terminated and the databases crash without getting a chance to close gracefully. In a recent meeting with scar and kps ,we decided the solution to this would be running seaweedfs as a docker container.