Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The list view should only return visible candidates #21

Merged
merged 1 commit into from
Nov 29, 2020
Merged

The list view should only return visible candidates #21

merged 1 commit into from
Nov 29, 2020

Conversation

helpermethod
Copy link
Member

Fixes #20.

@helpermethod
Copy link
Member Author

I'll add a few more tests and squash the commits.

marc0der
marc0der reviewed Nov 28, 2020
View reviewed changes
Copy link
Member

@marc0der marc0der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a big thing, but shall we use the new finder method explicitly for getting visible versions? It will make the code clearer to understand.

@helpermethod
Copy link
Member Author

It's not a big thing, but shall we use the new finder method explicitly for getting visible versions? It will make the code clearer to understand.

Yes that makes sense.

@helpermethod
Copy link
Member Author

Switched to the new finder method, improved the Cucumber spec and squashed all commits.

@marc0der marc0der merged commit fc25b96 into sdkman:master Nov 29, 2020
@marc0der
Copy link
Member

This is awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc0der marc0der marc0der approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The list view should only return visible candidates
2 participants
@helpermethod @marc0der