Add password configuration to datasource settings #17
Conversation
This currently bumps the minimum Grafana version to 9.1.0 through use of `SecretInput`, which isn't ideal - perhaps we could copy/paste that component in instead, or just write our own. Closes #16.
sd2k
force-pushed
the
add-password-support
branch
from
2a76870 to
93c25c9
Compare
| @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
|
|
|||
| - Add a 'password' field to the datasource settings and pass this when connecting to Materialize. This is required for Materialize Cloud. | |||
There was a problem hiding this comment.
| - Add a 'password' field to the datasource settings and pass this when connecting to Materialize. This is required for Materialize Cloud. | |
| - Add a `password` field to the datasource settings and pass this when connecting to Materialize. This is required for Materialize Cloud. |
Only because it's not available in Grafana < 9.1, so only people with Grafana 9.1.0 or higher could use the plugin. That's unlikely to be an issue though, I guess? I should definitely bump the minimum Grafana version in the plugin though... |
|
This is definitely a needed addition for Materialize Cloud, however it would seem to make sense to add a cluster option as well to be able to default the cloud cluster to run the query against, thus not having to add a set cluster statement to every query. |
Ah, thanks for this. I'll make sure to add the cluster option too. I'm still waiting for access to MZ Cloud which I need to test this PR though, not sure how long that'll take. |
This currently bumps the minimum Grafana version to 9.1.0 through use of
SecretInput, which isn't ideal - perhaps we could copy/pastethat component in instead, or just write our own.
Closes #16.