dist: drop Java tools and change packaging just for cassandra-stress #384
Conversation
| Architecture: all | ||
| Depends: %{product}-conf, %{product}-tools-core, ${misc:Depends} | ||
| Priority: optional |
There was a problem hiding this comment.
since you are specifying the "Priority" of this package. i'd suggest either do the same to ${product}-cassandra-stress, or just drop both of them. because, according to Debian Policy Manual,
extra
This priority is deprecated. Use the optional priority instead. This priority should be treated as equivalent to optional.
There was a problem hiding this comment.
Added Priority: optional to %{product}-cassandra-stress and %{product}-cassandra-stress.
|
|
||
| Package: %{product}-cassandra-stress | ||
| Architecture: all | ||
| Depends: %{product}-conf, %{product}-cassandra-stress-core, ${misc:Depends} | ||
| Recommends: ntp | time-daemon |
There was a problem hiding this comment.
ntp and time-daemon were added in https://issues.apache.org/jira/browse/CASSANDRA-4606 and https://issues.apache.org/jira/browse/CASSANDRA-5816 respectively. they intended to run a cassandra cluster . but cassandra-stress as a client-side tool, it does not rely on a ntp or chrony service to operate. so i'd suggest take this opportunity to drop them.
|
I think scylladb/scylla-ccm#565 has to go in, before we can merge this. |
syuu1228
force-pushed
the
packaging_just_for_cassandra_stress
branch
from
448006b
to
e82d976
Compare
@denesb It was merged yesterday, can we merge this one? |
Not yet. The above PR was reduced in scope to just prepare ccm for the post JMX world. Throwing out all of Java on on go proved too big of a bite, to chew at once. I just realized we also didn't yet finish scylladb/scylladb#14856, notably, there are still dtests around testing the java tools. These need to be either:
|
syuu1228
force-pushed
the
packaging_just_for_cassandra_stress
branch
from
e82d976
to
ee4654d
Compare
|
Rebased, since it was conflicted. |
|
I need to modify Obsoletes/Breaks/Replaces on this patch, since I supposed next release version is 5.5 so I wrote something like |
Since Java based tools are deprecated and now we only need cassandra-stress, change package name to "scylla-cassandra-stress" and drop deprecated tools from the package. Closes scylladb#370
syuu1228
force-pushed
the
packaging_just_for_cassandra_stress
branch
from
ee4654d
to
fbf55a3
Compare
|
Replaced |
|
I think this one is not needed and this task #370 misled you. We can/should keep the packaging as "scylla-tools-java" and c-s will be part of it. So, the packaging can remain as scylla-tools-java but just not a dependency of scylladb. |
Since Java based tools are deprecated and now we only need cassandra-stress, change package name to "scylla-cassandra-stress" and drop deprecated tools from the package.
Closes #370