Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Scylla Operator resources configurable in CI scripts #2276

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Make Scylla Operator resources configurable in CI scripts #2276

merged 1 commit into from
Jan 13, 2025

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Dec 17, 2024 •
edited
Loading

Description of your changes: This PR makes Scylla Operator resources configurable in CI scripts. It also adds a shared env file, sourced by scripts running e2e tests, which by default configures the operator with a guaranteed QoS class. This is a step towards stabilising our CI.

Which issue is resolved by this Pull Request:
Resolves https://github.com/scylladb/scylla-operator-release/issues/363

/kind machinery
/priority important-soon
/cc

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes: wip

Which issue is resolved by this Pull Request:
Resolves #

/kind machinery
/priority important-soon
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2024
@rzetelskik rzetelskik force-pushed the operator-resources-ci branch 4 times, most recently from 469008d to 70713cb Compare December 17, 2024 16:18
@rzetelskik rzetelskik force-pushed the operator-resources-ci branch from 70713cb to e284784 Compare January 8, 2025 14:16
@scylla-operator-bot scylla-operator-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2025
@rzetelskik rzetelskik force-pushed the operator-resources-ci branch 3 times, most recently from f68c5a8 to 98d48f5 Compare January 9, 2025 13:23
@rzetelskik rzetelskik mentioned this pull request Jan 10, 2025
Merged
@rzetelskik rzetelskik force-pushed the operator-resources-ci branch 5 times, most recently from 7d220db to f288d70 Compare January 13, 2025 09:56
@rzetelskik rzetelskik force-pushed the operator-resources-ci branch 2 times, most recently from aa327de to 73e4bc3 Compare January 13, 2025 11:07
@rzetelskik rzetelskik changed the title [WIP] Make Scylla Operator resources configurable in CI scripts Make Scylla Operator resources configurable in CI scripts Jan 13, 2025
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@rzetelskik
Copy link
Member Author

/cc zimnx mflendrich

@rzetelskik rzetelskik mentioned this pull request Jan 13, 2025
Open
mflendrich
mflendrich approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@mflendrich mflendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mflendrich, rzetelskik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2025
@scylla-operator-bot scylla-operator-bot bot merged commit 95ab06c into scylladb:master Jan 13, 2025
14 checks passed
@rzetelskik rzetelskik deleted the operator-resources-ci branch January 13, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflendrich mflendrich mflendrich approved these changes

@zimnx zimnx Awaiting requested review from zimnx

Assignees

@mflendrich mflendrich

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzetelskik @mflendrich