Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an e2e test for retryable NodeConfig mount units #2253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Dec 12, 2024

Description of your changes: It seems that the scenario described in #1559 has been covered by #2134. I wasn't able to find a scenario that would differentiate the case where a mount unit would require a restart to end up in an active state (as opposed to just starting it again as we do now), so this PR only adds an e2e covering the scenario described in the issue. We can go back to discussing the restarts if an actual scenario comes up.

Which issue is resolved by this Pull Request:
Resolves #1559

/kind feature
/priority important-longterm
/cc

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 12, 2024
Copy link
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes: wip

Which issue is resolved by this Pull Request:
Resolves #

/kind feature
/priority important-longterm
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@scylla-operator-bot scylla-operator-bot bot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2024
@rzetelskik rzetelskik force-pushed the retry-mounts branch 4 times, most recently from 23d1880 to 752ef07 Compare December 17, 2024 11:06
@rzetelskik rzetelskik changed the title [WIP] Restart failed NodeConfig mount units Add an e2e test for retryable NodeConfig mount units Dec 17, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
@rzetelskik rzetelskik changed the title Add an e2e test for retryable NodeConfig mount units [WIP] Add an e2e test for retryable NodeConfig mount units Dec 17, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
@rzetelskik rzetelskik changed the title [WIP] Add an e2e test for retryable NodeConfig mount units Add an e2e test for retryable NodeConfig mount units Dec 17, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
@rzetelskik
Copy link
Member Author

/cc zimnx tnozicka
ptal

Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign tnozicka

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@rzetelskik
Copy link
Member Author

ping @tnozicka

Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

please
/hold
for #1955 (conflicts)

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry NodeConfig mounts
3 participants