Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelized cluster hosts discovering + async config cache update #4077

Merged
merged 8 commits into from
Nov 28, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review fix
karol-kokoszka committed Nov 26, 2024

Verified

This commit was signed with the committer’s verified signature.
commit f679981d2b87adc7d6196eec0a1a387ae2be85e9
5 changes: 3 additions & 2 deletions pkg/service/cluster/service.go
Original file line number Diff line number Diff line change
@@ -230,11 +230,12 @@ func (s *Service) discoverClusterHosts(ctx context.Context, c *Cluster) (knownHo
}()

// Read results until the channel is closed
for hosts := range result {
hosts, ok := <-result
if ok {
return hosts.known, hosts.live, nil
}

// If no valid results, return error<
// If no valid results, return error
return nil, nil, ErrNoValidKnownHost
}