Restore improvement: batch #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the initial design, that was changed during implementation by mistake. We should always send shard_cnt * --batch-size sstables in a single restore job, even when user wants to restore into a running cluster. For this case, it should be enough to set --parallel=1 and --batch-size=1 for a slow running restore.
Michal-Leszczynski
force-pushed
the
ml/restore-batch
branch
2 times, most recently
from
0447b3d
to
03856a9
Compare
This commit allows to set --batch-size=0. When this happens, batches will be created so that they contain about 5% of expected node workload during restore. This allows for creating big, yet evenly distributed batches without the need to play with the --batch-size flag. It should also work better fine when backed up cluster had different amount of nodes than the restore destination cluster. Fixes #4059
This shouldn't be possible, but we can still validate that.
This results in creating batches of sstables of more similar size. Fixes #3979
Michal-Leszczynski
force-pushed
the
ml/restore-batch
branch
from
03856a9
to
ac72b54
Compare
|
@karol-kokoszka This PR is ready for review! |
karol-kokoszka
approved these changes
Oct 3, 2024
This allows not to bother with small, badly distributed over shards leftover batches.
Michal-Leszczynski
force-pushed
the
ml/restore-batch
branch
from
0f6684d
to
479c4d8
Compare
Michal-Leszczynski
force-pushed
the
ml/restore-batch
branch
from
479c4d8
to
f235b5d
Compare
|
@karol-kokoszka I addressed the comments, could you take a look again? |
karol-kokoszka
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes to batching mechanism:
Fixes #3979
Fixes #4059