Restore: rely on run.units instead of target.keyspace #4040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting over manifests Target.keyspace is calculated at the beginning of each restore task run. It is vulnerable for changes occurring during restore process, e.g.: - restore targeting some views is started - target.keyspace excludes restored views (checked via CQL query) - restore is paused - restore is resumed - recalculated target.keyspace no longer excludes restored views Units are calculated only once at the beginning of the restore, so they are not vulnerable to mentioned changes and should be used to determine which tables should be restored. Fixes #4037
Michal-Leszczynski
force-pushed
the
ml/fix-4037
branch
from
6bd0a7a
to
1dd041d
Compare
|
@karol-kokoszka This PR is ready for review! |
|
@karol-kokoszka Could you take a look? |
|
@karol-kokoszka The first round of comments has been addressed! |
This commit adds runPausedRestore function which allows to run restore which is going to be interrupted every specified interval. Pausing after some arbitrary amount of time might seem flaky, but we can't always rely on scyllaclient hooks for pausing restore, as we are biased to where we put them. This commit also alters runPausedRestore to include views in schema and the backup, so that it can test for #4037.
Michal-Leszczynski
force-pushed
the
ml/fix-4037
branch
from
1dd041d
to
85bb35e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target.keyspace is calculated at the beginning of each restore task run.
It is vulnerable for changes occurring during restore process, e.g.:
Units are calculated only once at the beginning of the restore,
so they are not vulnerable to mentioned changes and should
be used to determine which tables should be restored.
Fixes #4037