-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: explain --all-clusters in backup list #3811
Conversation
@annastuchlik Could you please take a look at this PR ? There were a lot of question asking if customer can somehow remove the backup of non-existing cluster from the backup location. |
@karol-kokoszka I need to understand the problem better before I provide any feedback. My understanding is that there are two issues with the
I'm guessing because the description explains how it works under the hood, but it's unclear to me what the user should do. Next:
This PR updates the description of the Finally, perhaps we should add instructions on how to remove backups to the Backup page. |
That's correct.
That's very good point, and I agree with you that the explanation should be added to the general backup description.
Makes sense, let me update
Yes, will add the commit. @annastuchlik Thanks for the follow up questions ! |
119383a
to
3a551c4
Compare
@annastuchlik PR updated. |
@annastuchlik ping. I appreciate your view on the documentation and don't want to merge changes without it. |
@karol-kokoszka I've left two suggestions for language improvements, and I'm approving this PR, as all the information is there. Thanks! |
652dbbe
to
7644377
Compare
Fixes #3780
Please make sure that: