Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch sstables basing on percentage of the node's data #4059

Open
Michal-Leszczynski opened this issue Oct 3, 2024 · 0 comments · May be fixed by #4055
Open

Batch sstables basing on percentage of the node's data #4059

Michal-Leszczynski opened this issue Oct 3, 2024 · 0 comments · May be fixed by #4055
Assignees
Labels
Milestone

Comments

@Michal-Leszczynski
Copy link
Collaborator

As described in this comment, SM should make it easier to set optimal --batch-size for restoring as fast as possible.

In order to achieve that, we should add a special --batch-size=0 value meaning that we want to create batches that result in the fastest restore. This follows the convention used by other flags like --parallel or --rate-limit.

Setting --batch-size=0 would result in sending batches of unlimited amount of sstables, but of size up to 5% of expected node workload.

@Michal-Leszczynski Michal-Leszczynski added this to the 3.4 milestone Oct 3, 2024
@Michal-Leszczynski Michal-Leszczynski self-assigned this Oct 3, 2024
Michal-Leszczynski added a commit that referenced this issue Oct 3, 2024
This commit allows to set --batch-size=0.
When this happens, batches will be created so that they contain
about 5% of expected node workload during restore.
This allows for creating big, yet evenly distributed batches
without the need to play with the --batch-size flag.
It should also work better fine when backed up cluster
had different amount of nodes than the restore destination
cluster.

Fixes #4059
@Michal-Leszczynski Michal-Leszczynski linked a pull request Oct 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant