Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop retruning status_code=2 on schema disagreement #57

Merged
merged 1 commit into from
Dec 25, 2023
Merged

stop retruning status_code=2 on schema disagreement #57

merged 1 commit into from
Dec 25, 2023

Conversation

fruch
Copy link
Collaborator

@fruch fruch commented Oct 10, 2023

So far if a query is executed during schema changes that takes more then 5sec to be resolved, cqlsh would print a warning and change the return status to failure.

if it's just a warning, we shouldn't be failure the command. especily since after this warning we are waiting without a timeout for schema to be resolved.

Fixes: #34

@avikivity
Copy link
Member

title is confused

@fruch fruch changed the title if isn't agreed cqlsh won't be returning failure stop failing on schema agreement Oct 10, 2023
@fruch
stop retruning status_code=2 on schema disagreement
6912ad6 
So far if a query is executed during schema changes that takes
more then 5sec to be resolved, cqlsh would print a warning
and change the return status to failure.

if it's just a warning, we shouldn't be failure the command.
especily since after this warning we are waiting without a timeout
for schema to be resolved.

Fixes: scylladb#34
@fruch fruch changed the title stop failing on schema agreement stop retruning status_code=2 on schema disagreement Oct 10, 2023
roydahan
roydahan approved these changes Dec 24, 2023
View reviewed changes
Copy link
Collaborator

@roydahan roydahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and quite trivial change).

@roydahan
Copy link
Collaborator

Why is this PR stuck here for so long?
Who is the maintainer here?

@fruch
Copy link
Collaborator Author

fruch commented Dec 25, 2023

Why is this PR stuck here for so long? Who is the maintainer here?

currently me and @Lorak-mmk

it's stuck cause it's forgotten, and people keep opening an issue on scylla for this.

@mykaul
Copy link
Contributor

mykaul commented Dec 25, 2023

Why is this PR stuck here for so long? Who is the maintainer here?

currently me and @Lorak-mmk

it's stuck cause it's forgotten, and people keep opening an issue on scylla for this.

There's no milestone or priority, so we cannot track it for a specific release and prioritize / de-prioritize it.

@fruch
Copy link
Collaborator Author

fruch commented Dec 25, 2023

Why is this PR stuck here for so long? Who is the maintainer here?

currently me and @Lorak-mmk
it's stuck cause it's forgotten, and people keep opening an issue on scylla for this.

There's no milestone or priority, so we cannot track it for a specific release and prioritize / de-prioritize it.

also this one didn't had any conclusion, and doesn't have priority or target:
scylladb/scylladb#13299

this was based on information there, the discussion there went to all kind of places, not suggesting any fix whatsoever.

@fruch fruch merged commit 0f91c3e into scylladb:master Dec 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roydahan roydahan roydahan approved these changes

@Lorak-mmk Lorak-mmk Awaiting requested review from Lorak-mmk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cqlsh shouldn't be returning failure on cases of schema disagreement
4 participants
@fruch @avikivity @roydahan @mykaul