setup.py: explicitly specify cython's language_level #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and void not in condition expression, for better readability. Signed-off-by: Kefu Chai <[email protected]>
less indent, for better readability. Signed-off-by: Kefu Chai <[email protected]>
according to Cython document, the first parameter passed to `cythonize()` should be "a glob pattern, a list of glob patterns or a list of Extension objects". so let's pass a list of Extensions instead of a single instance of `Extension`. Signed-off-by: Kefu Chai <[email protected]>
to silence the warning of ``` /tmp/build-env-p23crgfa/lib64/python3.11/site-packages/Cython/Compiler/Main.py:384: FutureWarning: Cython directive 'language_level' not set, using '3str' for now (Py3). This has changed from earlier releases! File: /home/kefu/dev/scylladb/tools/cqlsh/cqlshlib/copyutil.py tree = Parsing.p_module(s, pxd, full_module_name) ``` "3str" is the new default. so this change has no impact on the cythonized python code. with this option, the unprefixed strings are considered "str" objects. for more details, please see https://cython.readthedocs.io/en/latest/src/userguide/migrating_to_cy30.html#python-3-syntax-semantics Signed-off-by: Kefu Chai <[email protected]>
|
@fruch hi Israel, could you help review this change as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this series restructures
get_extensions(), and also silences the warning like: