Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager): update default Scylla version to 2024.2 for Manager tests #9622

Merged

Conversation

mikliapko
Copy link
Contributor

@mikliapko mikliapko commented Dec 27, 2024

Default scylla_version is set to 2024.2 instead of 2024.1.

At the same time, to have some coverage for 2024.1 as well, all Debian 11 jobs adjusted to use version 2024.1.

Testing

  • ubuntu22 sanity test

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

@mikliapko mikliapko added the backport/none Backport is not required label Dec 27, 2024
@mikliapko mikliapko self-assigned this Dec 27, 2024
Default scylla_version is set to 2024.2 instead of 2024.1.

At the same time, to have some coverage for 2024.1 as well, all Debian11
jobs adjusted to use version 2024.1.

Related test_get_manager_scylla_backend_returns_repo_address test is
adjusted too.
@mikliapko mikliapko force-pushed the update-default-scylla-versions-for-manager branch from 42f83d2 to 4bd3f86 Compare December 27, 2024 10:58
@mikliapko mikliapko requested a review from a team December 27, 2024 12:03
@mikliapko mikliapko marked this pull request as ready for review December 27, 2024 12:03
@mikliapko mikliapko requested a review from rayakurl as a code owner December 27, 2024 12:03
@mikliapko mikliapko requested review from karol-kokoszka and Michal-Leszczynski and removed request for rayakurl December 27, 2024 12:04
@@ -9,6 +9,8 @@ managerPipeline(
test_name: 'mgmt_cli_test.ManagerInstallationTests.test_manager_installed_and_functional',
test_config: '''["test-cases/manager/manager-installation-set-distro.yaml", "configurations/manager/debian11.yaml"]''',

scylla_version: '2024.1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be 2024.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put 2024.1 there by purpose for debian jobs to keep some coverage for 2024.1 too since it's still used in Production.

@mikliapko mikliapko requested a review from soyacz December 30, 2024 16:11
Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit 9912e13 into scylladb:master Jan 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/none Backport is not required promoted-to-master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants