-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stress-threads): kill only labeled docker containers on loaders #9235
Conversation
There is no any filtering of docker instances, when killing containerized stress threads on loader nodes during teardown of a test. In the case of docker backend this can result in deleting all containers in the system. The change fixes this by labeling stress thread related docker containers when they are created; and deleting only the labeled containers during the teardown. Fixes: scylladb#9027
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dimakr how did you test it? |
As it is against docker backend I tested/executed it locally (pausing at the corresponding places to ensure that stress containers are labeled as expected and can be filtered by the labels). And ran |
I suppose people use docker backends with sct master only - as we develop tests on this branch mainly. |
There is no any filtering of docker instances, when killing containerized stress threads on loader nodes during teardown of a test. In the case of docker backend this can result in deleting all containers in the system.
The change fixes this by labeling stress thread related docker containers when they are created; and deleting only the labeled containers during the teardown.
Fixes: #9027
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)