[Backport 2024.2] fix(kms): set proper node regions in multi-dc setups #9041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The AWS-KMS code in DB node python class uses shared dictionary from the DB cluster class for updating the KMS endpoint region. It was not a problem when DB nodes setup was serial. In this case shared object was changed by each node but had proper value in needed time frame. After implementation of the parallel DB nodes setup [1] we started getting problems that only one state of that shared object was being applied for all nodes. In single-dc setups everything was correct just because there was no diff among DB node's region names. But in multi-dc setups values from DB nodes started being applied to each other. So, fix it by just deep-copying that shared dictionary to avoid updates of a shared object. [1] #7383 Closes: #9025 (cherry picked from commit ce56367)
vponomaryov
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS-KMS code in DB node python class uses shared dictionary
from the DB cluster class for updating the KMS endpoint region.
It was not a problem when DB nodes setup was serial.
In this case shared object was changed by each node but had proper value in needed time frame.
After implementation of the parallel DB nodes setup (#7383)
we started getting problems that only one state of that shared object was being applied for all nodes.
In single-dc setups everything was correct just because there was no diff among DB node's region names.
But in multi-dc setups values from DB nodes started being applied to each other.
So, fix it by just deep-copying that shared dictionary to avoid updates of a shared object.
Closes: #9025
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)(cherry picked from commit ce56367)
Parent PR: #9026