Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(update-db-packages): stop only updated nodes #8857

Merged

Conversation

soyacz
Copy link
Contributor

@soyacz soyacz commented Sep 27, 2024

When updating multiple nodes db packages, SCT stops all the nodes. This is wrong and causes tests to fail when providing update_db_packages param.

Fix by removing broken logic and dropping code for nodes stop ordering.

fixes: #8551

Testing

  • [ ]

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

When updating multiple nodes db packages, SCT stops all the nodes.
This is wrong and causes tests to fail when providing
`update_db_packages` param.

Fix by removing broken logic and dropping code for nodes stop ordering.

fixes: scylladb#8551
@soyacz soyacz requested review from fruch and dimakr September 27, 2024 06:13
@soyacz soyacz added backport/2024.1 Need backport to 2024.1 backport/perf-v15 backport/2024.2 Need backport to 2024.2 backport/6.1 Need backport to 6.1 backport/6.2 labels Sep 27, 2024
Copy link
Contributor

@dimakr dimakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade db packages stops all nodes when growing cluster by 3 in parallel (custom db packages)
4 participants