Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(github): cache github issues status in S3 #7701

Merged
merged 1 commit into from
Jun 24, 2024
Merged

feature(github): cache github issues status in S3 #7701

merged 1 commit into from
Jun 24, 2024

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Jun 20, 2024 •
edited
Loading

Ref: https://github.com/scylladb/qa-tasks/issues/1678

Testing

  • [ ]

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@fruch fruch force-pushed the process_cache_issues_status branch 7 times, most recently from 440765c to a6ff35b Compare June 20, 2024 21:45
@fruch fruch added backport/2023.1 Need to backport to 2023.1 backport/5.4 Need backport to 5.4 backport/2024.1 Need backport to 2024.1 backport/6.0 labels Jun 20, 2024
fruch
fruch commented Jun 20, 2024
View reviewed changes
sdcm/utils/issues.py Outdated Show resolved Hide resolved
@fruch fruch requested review from soyacz and roydahan June 20, 2024 21:48
soyacz
soyacz reviewed Jun 21, 2024
View reviewed changes
sdcm/utils/issues.py Outdated Show resolved Hide resolved
sdcm/utils/issues.py Outdated Show resolved Hide resolved
sdcm/utils/issues.py Outdated Show resolved Hide resolved
sdcm/utils/issues.py Show resolved Hide resolved
.github/workflows/cache-issues.yaml Show resolved Hide resolved
.github/workflows/cache-issues.yaml Outdated Show resolved Hide resolved
.github/workflows/cache-issues.yaml Show resolved Hide resolved
@soyacz
Copy link
Contributor

soyacz commented Jun 21, 2024

I wonder also about if this cache could be reused by Argus. In that case we might want to also cache also issue titles.

@fruch fruch force-pushed the process_cache_issues_status branch from a6ff35b to a8b306b Compare June 23, 2024 20:18
@fruch
feature(github): cache github issues status in S3
ec52c62 
one github action that runs once a day, that
caches the issues status from multiple github repositories

and client code that can read those csv files and cache
them locally, so SkipPerIssue can read first out of it
and then fallback into doing direct github API calls

Ref: scylladb/qa-tasks#1678
@fruch fruch force-pushed the process_cache_issues_status branch from a8b306b to ec52c62 Compare June 24, 2024 06:10
soyacz
soyacz approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit 8c267c2 into master Jun 24, 2024
7 checks passed
@mergify mergify bot mentioned this pull request Jun 24, 2024
Merged
2 tasks
This was referenced Jun 24, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyacz soyacz soyacz approved these changes

@roydahan roydahan Awaiting requested review from roydahan

Assignees

@fruch fruch

Labels
backport/5.4 Need backport to 5.4 backport/6.0 backport/2023.1 Need to backport to 2023.1 backport/2024.1 Need backport to 2024.1 promoted-to-master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fruch @soyacz @scylladbbot