Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrades): replace sstabledump with scylla sstable dump-data #6463

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Aug 6, 2023

cause of new sstable uuid identifer feature the old sstabledump can't currently work with those sstables

Ref: scylladb/scylla-tools-java#333

Testing

PR pre-checks (self review)

  • I followed KISS principle and best practices
  • I didn't leave commented-out/debugging code
  • I added the relevant backport labels
  • New configuration option are added and documented (in sdcm/sct_config.py)
  • I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)
  • All new and existing unit tests passed (CI)
  • I have updated the Readme/doc folder accordingly (if needed)

cause of new sstable uuid identifer feature the old `sstabledump`
can't currently work with those sstables

Ref: scylladb/scylla-tools-java#333
@fruch fruch force-pushed the remove_stabledump_from_upgrades branch from 53a21c5 to 4515fdb Compare August 6, 2023 11:49
Copy link
Contributor

@fgelcer fgelcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgelcer
Copy link
Contributor

fgelcer commented Aug 6, 2023

cause of new sstable uuid identifer feature the old sstabledump can't currently work with those sstables

Ref: scylladb/scylla-tools-java#333

Testing

this run above failed with the audit enabled on the Azure image... did it run the sstable command?

@fgelcer
Copy link
Contributor

fgelcer commented Aug 6, 2023

cause of new sstable uuid identifer feature the old sstabledump can't currently work with those sstables
Ref: scylladb/scylla-tools-java#333

Testing

this run above failed with the audit enabled on the Azure image... did it run the sstable command?

yes, i see the following:

15:58:50  < t:2023-08-06 12:58:36,658 f:file_logger.py  l:101  c:sdcm.sct_events.file_logger p:INFO  > 2023-08-06 12:58:36.648: (InfoEvent Severity.NORMAL) period_type=not-set event_id=ba5cc4a1-63dd-4e96-bada-29356af06197: message=Step10 - Verify that gemini did not failed during upgrade
15:58:50  < t:2023-08-06 12:58:36,666 f:file_logger.py  l:101  c:sdcm.sct_events.file_logger p:INFO  > 2023-08-06 12:58:36.649: (InfoEvent Severity.NORMAL) period_type=not-set event_id=fb827709-989a-45bc-b53f-9dccd5f4b925: message=all nodes were upgraded, and last workaround is verified.
15:58:50  < t:2023-08-06 12:58:36,670 f:file_logger.py  l:101  c:sdcm.sct_events.file_logger p:INFO  > 2023-08-06 12:58:36.649: (InfoEvent Severity.NORMAL) period_type=not-set event_id=cc3b5ab3-1a73-4fef-bd13-79238627aafe: message=TEST_END

@fruch fruch merged commit cd69a61 into scylladb:master Aug 7, 2023
@fruch fruch added backport/2023.1 Need to backport to 2023.1 backport/2023.1-done Commit backported to 2023.1 labels Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/2023.1-done Commit backported to 2023.1 backport/2023.1 Need to backport to 2023.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants