Skip to content

Commit

Permalink
fix(workload_types): adjust workload comparison
Browse files Browse the repository at this point in the history
in last enterprise-master(2024.1.3) deviation of workloads was improved
and the test started failing with errors like:
"Actual ratio (0.9841362837441976) is not as expected (2.0)"

I assume it was implemented by design to hit such
improvement and adjust tests accordingly.

value comparison_axis was adjuster for version >=2024.3
  • Loading branch information
temichus committed Oct 7, 2024
1 parent dd26532 commit 2b2ef12
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions sla_per_user_system_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -828,6 +828,12 @@ def _compare_workloads_c_s_metrics(self, workloads_queue: list) -> dict:
comparison_axis = {"latency 95th percentile": 2.0,
"latency 99th percentile": 2.0,
"op rate": 2.0}
release = parse_version(self.db_cluster.nodes[0].scylla_version.replace("~", "-")).release
if release[0] > 2024 or (release[0] == 2024 and release[1] >= 3):
# Running the test with 2024.3 - deviation was improved
comparison_axis = {"latency 95th percentile": 1.0,
"latency 99th percentile": 1.0,
"op rate": 1.0}
workloads_results = {}
for workload in workloads_queue:
result = self.get_stress_results(queue=workload, store_results=False)
Expand Down

0 comments on commit 2b2ef12

Please sign in to comment.