ansible-scylla-node: 'scylla-node-exporter' service is not enabled by default #249
Comments
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 15, 2023
This patch: - Changes the task name related to scylla-node-exporter service - Set the right service name - Fixes the indentation - Uses recommended name format for the module used Ref: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 15, 2023
Ref: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 15, 2023
…s available Ref: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 15, 2023
This patch will run 'node_exporter_install' only if current Scylla version is < 5.0 / 2022 Ref: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 15, 2023
…orter_install' setup Before this patch, the whole task used an 'ignore_error'. This patch will check if 'node-exporter.service' exists, and based on that, will decide to force or not the installation. That should get rid of any potential error. This patch affect a "legacy" piece of code since. Ref: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 15, 2023
…exporter service exists This patch solves an incompatibility problem when both services exist, commonly seen after an upgrade. Ref: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 16, 2023
… service This patch enables and start 'scylla-node-exporter.service' service and disables and stop (if exists) 'node-exporter.service'. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 16, 2023
… service This patch enables and start 'scylla-node-exporter.service' service and disables and stop (if exists) 'node-exporter.service'. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 16, 2023
… service This patch enables and start 'scylla-node-exporter.service' service and disables and stop (if exists) 'node-exporter.service'. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 16, 2023
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 16, 2023
… service This patch enables and start 'scylla-node-exporter.service' service and disables and stop (if exists) 'node-exporter.service'. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 16, 2023
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 16, 2023
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 16, 2023
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
|
@ebenzecri we reverted your change due to a problem in training |
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 21, 2023
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 21, 2023
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 21, 2023
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 21, 2023
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 21, 2023
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 21, 2023
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 21, 2023
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
ebenzecri
added a commit
to ebenzecri/scylla-ansible-roles
that referenced
this issue
Jun 21, 2023
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
'scylla-node-exporter' service is started but not enabled automatically by the role.
The text was updated successfully, but these errors were encountered: