Skip to content

Commit

Permalink
ansible-scylla-node: Runs 'node_exporter_install' just for old versions
Browse files Browse the repository at this point in the history
This patch will run 'node_exporter_install' only if current Scylla version is < 5.0 / 2022

Ref: scylladb#249

Signed-off-by: Eduardo Benzecri <[email protected]>
  • Loading branch information
ebenzecri committed Jun 15, 2023
1 parent 564600f commit 01072bb
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion ansible-scylla-node/tasks/common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,13 @@
- name: node exporter setup
shell: |
node_exporter_install --force
when: install_type == 'online'
become: true
notify:
- node_exporter start
ignore_errors: true
when:
- install_type == 'online'
- ansible_facts.services["scylla-node-exporter.service"] is not defined
#TODO: stop ignoring errors when the node_exporter_install script fix is available in all actual versions, resp. use only for < 5.0 / 2022

- name: Enable 'scylla-node-exporter' service
Expand Down

0 comments on commit 01072bb

Please sign in to comment.