Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to add ALLOW FILTERING to the update query #290

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Add option to add ALLOW FILTERING to the update query #290

merged 1 commit into from
Sep 10, 2024

Conversation

sylwiaszunejko
Copy link
Collaborator

Previously it was only possible to use AllowFiltering() on the select query builder.

This PR adds the option to add ALLOW FILTERING to the update query.

Fixes: #288

@sylwiaszunejko
Copy link
Collaborator Author

@dkropachev should different types of queries also have this option?

@sylwiaszunejko sylwiaszunejko self-assigned this Sep 10, 2024
@dkropachev dkropachev merged commit 6ba176a into scylladb:master Sep 10, 2024
1 check passed
@dkropachev
Copy link
Collaborator

@dkropachev should different types of queries also have this option?

yes, select as well

@sylwiaszunejko
Copy link
Collaborator Author

sylwiaszunejko commented Sep 10, 2024 •
edited
Loading

@dkropachev select already has it, any other?

@dkropachev
Copy link
Collaborator

@dkropachev select already has it, any other?

Then it is all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkropachev dkropachev dkropachev approved these changes

Assignees

@sylwiaszunejko sylwiaszunejko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to add ALLOW FILTERING to the query
2 participants
@sylwiaszunejko @dkropachev