Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3 - change v2 suffix to v3 #279

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

sylwiaszunejko
Copy link
Collaborator

Because of recent changes there is a need for a new major release. Changes are switching to scylladb/gocql and replacing Unsafe with Strict mechanism.

@sylwiaszunejko
Copy link
Collaborator Author

I have a problem with cmd/schemagen. I cannot use v3 there (e.g. in cmd/schemagen/testdata/go.mod) because release is not done yet. And because I changed module name in go.mod I had to add github.com/scylladb/gocqlx/v2 v2.8.0 to requirements to use v2 in cmd/schemagen. I am not sure how to do it better.
Now there will be a need for a second PR after the release to remove github.com/scylladb/gocqlx/v2 v2.8.0 from requirements and to change v2 to v3 in cmd/schemagen

@dkropachev
Copy link
Collaborator

@sylwiaszunejko , I have pushed commit that solves problem with schemagen, please take a look.

@sylwiaszunejko
Copy link
Collaborator Author

@dkropachev I don't know why but when I tried github.com/scylladb/gocqlx/v3 v3.0.0 in schemagen go.mod tests failed. Now it seems to work, maybe I did something wrong in the code

Copy link
Collaborator

@dkropachev dkropachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to tag it when it is merged, or before the merge.

Because of recent changes there is a need for a new major
release. Changes are switching to scylladb/gocql and replacing
Unsafe with Strict mechanism.
@dkropachev
Copy link
Collaborator

dkropachev commented Jul 10, 2024

@dkropachev I don't know why but when I tried github.com/scylladb/gocqlx/v3 v3.0.0 in schemagen go.mod tests failed. Now it seems to work, maybe I did something wrong in the code

It is my bad, on last PR to schemagen I have introduced test that actually compiles code from the test.
But I have missed the fact that it uses gocqlx as a external library, while it should be replaced with content from file system.
And it did not work for you because v3 is not yet published

@sylwiaszunejko
Copy link
Collaborator Author

sylwiaszunejko commented Jul 10, 2024

Please don't forget to tag it when it is merged, or before the merge.

I thought the correct steps were:

  1. merge this PR
  2. create a tag
  3. create a release from tag

Correct me if I am wrong

@sylwiaszunejko
Copy link
Collaborator Author

I thought the correct steps were:

  1. merge this PR
  2. create a tag
  3. create a release from tag

@mmatczuk Could you have a look at the PR? and confirm if I am right about steps for release?

@sylwiaszunejko
Copy link
Collaborator Author

@roydahan could you look at this?

@roydahan
Copy link
Collaborator

Looks fine to me.
We will need to highlight it in the release notes.

@sylwiaszunejko sylwiaszunejko merged commit e726792 into scylladb:master Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants