Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use scylla image instead of scylla version, to be able to target enterprise #277

Conversation

dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Jun 26, 2024

Currently Makefile uses SCYLLA_VERSION to define docker image.
Switching to SCYLLA_IMAGE instead will help to target enterprise, nightly or custom image

@dkropachev dkropachev force-pushed the dk/fix-makefile-switch-to-scylla-image-instead-of-version branch from 353081c to 7685318 Compare June 26, 2024 17:39
@sylwiaszunejko
Copy link
Collaborator

I am okay with merging this commit: Switch to use scylla image instead of scylla version, to be able to target enterprise
I would just suggest change to the commit message to something like that:

Switch to use scylla image instead of scylla version

Currently Makefile uses SCYLLA_VERSION to define docker image.
Switching to SCYLLA_IMAGE instead will help to target enterprise, nightly or custom image

but the second commit shouldn't be in this PR

@dkropachev dkropachev force-pushed the dk/fix-makefile-switch-to-scylla-image-instead-of-version branch from 7685318 to 717f51e Compare June 27, 2024 14:57
@dkropachev
Copy link
Collaborator Author

I am okay with merging this commit: Switch to use scylla image instead of scylla version, to be able to target enterprise I would just suggest change to the commit message to something like that:

Switch to use scylla image instead of scylla version

Currently Makefile uses SCYLLA_VERSION to define docker image.
Switching to SCYLLA_IMAGE instead will help to target enterprise, nightly or custom image

but the second commit shouldn't be in this PR

Commit leaked to master and I did not spot it right away, thanks, fixed

@sylwiaszunejko sylwiaszunejko merged commit fcd7608 into scylladb:master Jun 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants