fix(store): fix inf.Dec and big.Int compare #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illia-li
force-pushed
the
il/fix-store-compare_map_bigintv3
branch
from
c3e5c7b
to
0dd9953
Compare
illia-li
force-pushed
the
il/fix-store-compare_map_bigintv3
branch
4 times, most recently
from
2e0a3de
to
d04ca41
Compare
bhalevy
reviewed
Dec 19, 2023
pkg/store/comp/compare_info.go
Outdated
| @@ -0,0 +1,123 @@ | |||
| // Copyright 2019 ScyllaDB | |||
bhalevy
reviewed
Dec 19, 2023
| @@ -0,0 +1,137 @@ | |||
| // Copyright 2019 ScyllaDB | |||
bhalevy
reviewed
Dec 19, 2023
pkg/store/comp/utils_4test.go
Outdated
| @@ -0,0 +1,288 @@ | |||
| // Copyright 2019 ScyllaDB | |||
bhalevy
reviewed
Dec 19, 2023
pkg/store/cqlstore.go
Outdated
| @@ -90,11 +92,25 @@ func (cs *cqlStore) doMutate(ctx context.Context, builder qb.Builder, ts time.Ti | |||
| return nil | |||
| } | |||
|
|
|||
| func (cs *cqlStore) load(ctx context.Context, builder qb.Builder, values []interface{}) (result []map[string]interface{}, err error) { | |||
| func (cs *cqlStore) loadSV(ctx context.Context, builder qb.Builder, values []interface{}) (sv.Result, error) { | |||
There was a problem hiding this comment.
SV and MV are cryptic.
Why not expand them here?
bhalevy
reviewed
Dec 19, 2023
pkg/store/mv/c_list.go
Outdated
| @@ -0,0 +1,198 @@ | |||
| // Copyright 2019 ScyllaDB | |||
bhalevy
reviewed
Dec 19, 2023
pkg/store/mv/c_list.go
Outdated
| out += fmt.Sprintf("%d:%s;", idx, l[idx].ToString(listInfo.Elem)) | ||
| } | ||
| out = out[:len(out)-1] | ||
| return out + ">" |
There was a problem hiding this comment.
Can you modify the last char to > in place instead?
There was a problem hiding this comment.
Can't. It's string, simple chars modifications impossible. Modified to return out[:len(out)-1] + ">"
changes in check of responses rows procces: *rows data unmarshalling into byte slices. *rows data compare as byte slices, without transformation to 'GO' types. *rows diff information now more user friendly and can be customed. Diff collect row by row to string slice and can be transferred anywhere with better readable.
2) remake ColumnRaw to string instead []byte
illia-li
force-pushed
the
il/fix-store-compare_map_bigintv3
branch
from
49104c5
to
2fbfc33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As solution #405 (comment)
Main changes:
'gemini' productivity has increased on 30% for responses with big rows count and on 8% for responses with usual rows count.