Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT: adjust DCExecutionProfileTests to tablets #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muzarski
Copy link

There are two test suites for execution profiles.

  • ExecutionProfileTest - tests different execution profile setups with standard round-robin
  • DCExecutionProfileTest - tests dc aware execution profile setups

ExecutionProfileTest suite uses only 1 dc, while DCExecutionProfile uses 2 of them. Previously, they would both use an LWT insert statement. In this commit, we adjust DCExecutionProfileTest, so it uses non-LWT insert statement.

It looks like LWT statements are executed correctly for a single DC cluster. The DB error is returned for multi-dc clusters (Cannot use LightWeight Transactions for table ...).

There are two test suites for execution profiles.
- ExecutionProfileTest - tests different execution profile setups with standard round-robin
- DCExecutionProfileTest - tests dc aware execution profile setups

ExecutionProfileTest suite uses only 1 dc, while DCExecutionProfile uses 2 of them.
Previously, they would both use an LWT insert statement. In this commit,
we adjust DCExecutionProfileTest, so it uses non-LWT insert statement.

It looks like LWT statements are executed correctly for a single DC cluster.
The DB error is returned for multi-dc clusters (Cannot use LightWeight Transactions for table ...).
@dkropachev
Copy link
Collaborator

It looks like LWT statements are executed correctly for a single DC cluster. The DB error is returned for multi-dc clusters (Cannot use LightWeight Transactions for table ...).

Can you please look why, it should not be the case, unless there is difference between scylla configuration, scylla version or table creation statement.
TBH, this fix does not look like something correct, both cases should test same statements, at max we can skip LWT if tablets are on, but in such case we definitely should test non-LWT query in both cases in addition to LWT.

@muzarski
Copy link
Author

It looks like LWT statements are executed correctly for a single DC cluster. The DB error is returned for multi-dc clusters (Cannot use LightWeight Transactions for table ...).

Can you please look why, it should not be the case

True, I was confused when I discovered it.

I'll investigate it further then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants