Introduce c# load balancer #47
Conversation
dkropachev
force-pushed
the
dk/csharp-lb
branch
from
1426e86 to
49c1775
Compare
There was a problem hiding this comment.
I don't know anything about C sharp, so I'll believe that you tested it and merge this PR :-)
One thing I would like to ask (you can do it later, after I merge this) is to please add a README.md in the csharp directory, and add one in the future when you add more languages. Also please update the top-level README.md which contains a list of languages and after this patch - is no longer up-to-date.
I know you added a "Test" directory with an example, but I don't think it's enough. First, how would you know to look in the Test directory? But more importantly the test file contains a lot of irrelevant things and it's hard to find what is the important part to learn from. It also doesn't explain how things work, the motivation, and perhaps important issues like which versions of the SDK are supported (we had a lot to say about this in the Java).
| @@ -0,0 +1,317 @@ | |||
| using System; | |||
There was a problem hiding this comment.
We don't need to solve this now, but eventually, it would be nice not to have 17 different copies of the same AlternatorLiveNodes class in 17 different languages, each one with its own random bugs and forgetting to make the same fix all 17 versions. I don't have a solution how to do this. Maybe some sort of automatic translation? So code of home-brewed code generation? But will be nice to give this some thought one day.
In the meantime I'm ok with this manual one-off translation. You'll just need to remember that any future fix will need to go into all the different languages.
I have tested it against 6.2 and master, works as expected.