Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing c_coords argument in blobs multiscales #342

Merged
merged 2 commits into from
Aug 26, 2023

Conversation

aeisenbarth
Copy link
Contributor

This change is needed for tests in scverse/napari-spatialdata#153 to pass.

(You could seriously consider a monorepository that keeps related code and discussion together, but still release code as separate packages.)

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #342 (c741e34) into main (f58c4f4) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files          36       36           
  Lines        4678     4678           
=======================================
  Hits         4237     4237           
  Misses        441      441           
Files Changed Coverage Δ
src/spatialdata/datasets.py 100.00% <100.00%> (ø)

@LucaMarconato
Copy link
Member

Thanks a lot for the contribution, looks good to me. We never thought about a mono-repository actually; not sure about changing now, it would be quite some work, but we will think about it as it would definitely improve the discussions.

Also, we will certainly put effort to improve the documentation since it's scattered around the repos, and maybe put it all under one link as it is dispersive at the moment.

@LucaMarconato LucaMarconato merged commit dcf6a17 into scverse:main Aug 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants