Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting #3414

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Formatting #3414

merged 6 commits into from
Jan 10, 2025

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Dec 20, 2024

I don’t think we want pyproject-fmt, as it sorts our extras. We have so many of those that organizing becomes important. We probably just want to use taplo directly.

I configured Taplo to use pyproject-fmt style (120 columns, spaces inside of arrays and dicts), otherwise left the structure alone.

@flying-sheep flying-sheep changed the title WIP formatting Formatting Dec 20, 2024
@flying-sheep flying-sheep added this to the 1.11.0 milestone Dec 20, 2024
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.67%. Comparing base (e71dc55) to head (da4d218).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3414      +/-   ##
==========================================
+ Coverage   74.14%   76.67%   +2.52%     
==========================================
  Files         112      112              
  Lines       12945    12945              
==========================================
+ Hits         9598     9925     +327     
+ Misses       3347     3020     -327     

see 23 files with indirect coverage changes

@flying-sheep flying-sheep marked this pull request as ready for review January 9, 2025 13:52
pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Ilan Gold <[email protected]>
@flying-sheep flying-sheep merged commit c26290b into main Jan 10, 2025
4 of 12 checks passed
@flying-sheep flying-sheep deleted the pa/fmt branch January 10, 2025 07:52
kaushalprasadhial pushed a commit to sanchit-misra/scanpy that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants