Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate defunct order parameter in stacked_violin #3252

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Sep 20, 2024

That one never worked.

This PR also adds typing for categories_order, which has been supported.

@flying-sheep flying-sheep added this to the 1.10.4 milestone Sep 20, 2024
@flying-sheep flying-sheep changed the title Fix categories_order for class backed plots Warn for order parameter in stacked_violin Sep 20, 2024
@flying-sheep flying-sheep changed the title Warn for order parameter in stacked_violin Deprecate defunct order parameter in stacked_violin Sep 20, 2024
@flying-sheep flying-sheep marked this pull request as ready for review September 20, 2024 13:53
@flying-sheep flying-sheep mentioned this pull request Sep 20, 2024
3 tasks
@flying-sheep flying-sheep merged commit 874ce15 into main Sep 20, 2024
13 of 16 checks passed
@flying-sheep flying-sheep deleted the fix-categories-order branch September 20, 2024 14:13
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Sep 20, 2024
flying-sheep added a commit that referenced this pull request Sep 20, 2024
…er in `stacked_violin`) (#3253)

Co-authored-by: Philipp A <[email protected]>
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.74%. Comparing base (e27e257) to head (0744da6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/scanpy/plotting/_stacked_violin.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3252      +/-   ##
==========================================
- Coverage   76.75%   76.74%   -0.02%     
==========================================
  Files         109      109              
  Lines       12556    12559       +3     
==========================================
+ Hits         9637     9638       +1     
- Misses       2919     2921       +2     
Flag Coverage Δ
76.74% <33.33%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scanpy/plotting/_dotplot.py 92.24% <ø> (ø)
src/scanpy/plotting/_matrixplot.py 96.70% <ø> (ø)
src/scanpy/plotting/_stacked_violin.py 83.17% <33.33%> (-0.73%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant